Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hmr): subapp v1 #2024

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix(hmr): subapp v1 #2024

merged 1 commit into from
Sep 6, 2024

Conversation

shubham2811
Copy link
Contributor

@shubham2811 shubham2811 commented Sep 6, 2024 •
edited by arunvishnun
Loading

Summary

  • Fix an issue with HMR updates

@shubham2811 shubham2811 marked this pull request as ready for review September 6, 2024 16:34
@shubham2811 shubham2811 requested a review from a team as a code owner September 6, 2024 16:34
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

shubham2811 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

arunvishnun
arunvishnun approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@arunvishnun arunvishnun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arunvishnun arunvishnun merged commit 16ebc15 into master Sep 6, 2024
5 checks passed
@arunvishnun arunvishnun mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunvishnun arunvishnun arunvishnun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubham2811 @CLAassistant @arunvishnun